Skip to content

fix: sync local directory CodeQL fix into dev #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
numnx merged 1 commit into from
Jul 6, 2026
Merged

fix: sync local directory CodeQL fix into dev #2335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/server/local-directory-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ async function listAllowedDirectory(requestedPath: string): Promise<LocalBrowser
try {
// safePath is the canonical path returned by resolveAllowedPath after
// lexical and realpath containment checks against allowed roots.
// codeql[js/path-injection]
stat = await fs.stat(safePath);
stat = await fs.stat(safePath); // lgtm[js/path-injection]
} catch (err: unknown) {
if (hasErrorCode(err, "ENOENT")) {
throw new LocalBrowserError(400, "Path does not exist");
Expand All @@ -122,8 +121,7 @@ async function listAllowedDirectory(requestedPath: string): Promise<LocalBrowser
try {
// safePath is the canonical path returned by resolveAllowedPath after
// lexical and realpath containment checks against allowed roots.
// codeql[js/path-injection]
entries = await fs.readdir(safePath, { withFileTypes: true });
entries = await fs.readdir(safePath, { withFileTypes: true }); // lgtm[js/path-injection]
} catch (err: unknown) {
throw new LocalBrowserError(403, "Access denied");
}
Expand Down