fix: unblock resolved QA handoffs - #2876
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Resolving a task QA escalation cleared review rows and guardrail counters but left the task in QA_REVIEW_FAILED. Status derivation intentionally preserves that human-owned state, so restarting orchestration resumed the same blocked run forever. Separately, every completed same-session continuation qualified for another post-cap verification, allowing repeated no-op continuations to push a configured review budget far beyond its limit.
Impact
Resolved QA handoffs now re-enter review as intended, while exhausted reviews stop deterministically after one final post-cap verification. Already-settled tasks remain unchanged.
Validation
Risk and rollback
Risk is limited to task QA exhaustion and attention-resolution transitions. Roll back this commit to restore the prior behavior; paused sprint and task records remain durable and can be corrected through existing dashboard controls.