fix: gate model downloads and phonemize local speech - #2914
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Repair requiredWhy
Kokoro expects phoneme tokens. Machines without a system
espeak-ngbinary silently fell back to English spelling, which mapped to unrelated model tokens and made voices such as Bella sound foreign or unintelligible. Downloads also needed a consistent opt-in license boundary suitable for an MIT open-source application.Validation
pnpm run cipnpm run check:docs-webpassed/healthand/readyreturned healthy/ready after restarting the local runtimeRepair required, and theAccept & DownloaddialogRisk and rollback
Risk is concentrated in the new download acceptance contract and phonemizer subprocess. Existing clients that call download endpoints directly must send the catalog's
acceptedLicenseId. Existing Kokoro weights are reused, but the bundle remains unavailable until the small runtime is accepted and downloaded. Legacy Piper selections migrate to LJSpeech or Cori.Rollback by reverting this PR. Cached model files remain outside the application package and can be removed through the catalog. Reverting would restore the previous phonemization fallback, so it should be used only if the new runtime causes an operational regression.