fix: restore German 3D Chat text to speech - #2948
Merged
Merged
Conversation
# Conflicts: # docs-web/content/docs/user-dashboard-chat.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Selecting the German Piper model at system scope could leave a project-level English Kokoro voice override in place. The effective configuration therefore paired
piper-de-de-mls-mediumwith an unsupported voice id, causing the synthesis endpoint to return a provider failure while 3D Chat swallowed the error and appeared silently enabled.Impact
Installed local TTS models now remain usable after model changes at a parent settings scope. Existing stale voice overrides are repaired during effective settings resolution without requiring database edits, and any remaining synthesis or browser playback failure is visible and accessible in 3D Chat.
Validation
pnpm run lintpnpm run test:backend— 5,298 passed, 7 skippedpnpm run test:dashboard— 2,119 passed, 2 skippedpnpm run check:docs-webpnpm run buildRisk and rollback
Risk is limited to local TTS voice normalization and optional playback error presentation. Explicit API-requested voice ids retain their prior validation behavior. Roll back this commit to restore the previous settings and playback behavior; no database migration or persisted data rewrite is required.