fix: bound sprint QA follow-up completion - #2977
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The completion decision checked meaningful task changes before enforcing the sprint-QA cap, while handoff creation refused to run when meaningful changes existed. A sprint whose cap-reaching review created follow-up tasks could therefore complete all work but remain in a heartbeat loop with no review budget and no visible handoff. Earlier review cycles could also create an unrestricted final task batch with no remaining verification cycle.
Impact
Sprint completion remains fail-closed. At the configured cap, Code UX now surfaces an explicit operator decision instead of silently running forever, and the final review cannot expand the sprint with work that automation is not allowed to verify.
Validation
pnpm run lintpnpm exec vitest run tests/backend/domain/qa-review/sprint-qa-snapshot.test.ts tests/backend/services/quality-assurance-service.test.ts— 62 passedpnpm run test:backend— 5,334 passed, 7 skippedpnpm run check:docs-webpnpm run buildRisk and rollback
Risk is limited to sprint-completion QA exhaustion and final-cycle follow-up routing. Roll back this commit to restore the previous decision order; existing handoffs remain auditable and can be resolved through the normal operator flow.