fix: harden credential storage foundation - #2980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the automation credential store as a reliable foundation for additional credential types. The audit found no plaintext-at-rest fallback, but it did identify consistency, authorization-race, global-ownership, key-initialization, input-validation, and dashboard-integration gaps.
Security and reliability changes
400,403, and409outcomes for validation, policy denial, and concurrent-write conflicts.Regression coverage
New adversarial coverage verifies:
Validation
pnpm run ci/healthreturnedUP/readyreturned200 READY/api/credentials/healthreturned structured provider metadata with200Risk and rollback
The database migration adds management ownership metadata and a cleanup trigger. Legacy global credentials select their first valid allowlisted project as manager; operators should verify that owner before expanding legacy allowlists. New write limits and strict array validation can reject previously malformed payloads instead of coercing them. Roll back this merge commit if credential management or migration behavior regresses; encrypted envelope formats remain unchanged.