Skip to content

fix: repair sprint completion and add QA pass - #3011

Merged
numnx merged 1 commit into
devfrom
fix/sprint-completion-and-qa-pass
Jul 13, 2026
Merged

fix: repair sprint completion and add QA pass#3011
numnx merged 1 commit into
devfrom
fix/sprint-completion-and-qa-pass

Conversation

@numnx

@numnx numnx commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Replaced the generic sprint status patch behind Mark Completed with a runtime-aware manual completion endpoint.
  • Added Mark QA Pass to sprint card and ledger action menus, including pending, active-review, and already-passed states.
  • Persisted manual sprint QA passes as durable QA review runs and resolved matching sprint-scoped QA handoffs.
  • Added backend service, repository, route, dashboard, and failure-path coverage.
  • Updated canonical and published dashboard, QA, execution-control, and HTTP API documentation.

Why

The previous completion button changed only the sprint record. When a sprint run was still active, its runtime projection could immediately overwrite the manual completed status, making the button appear broken. Manual QA acceptance also had no sprint-page control or durable QA verdict.

User impact

  • Mark Completed now safely stops active sprint runtime work before persisting completion, so the state remains stable.
  • Mark QA Pass records an explicit manual pass after human review without dismissing task QA or unrelated attention.
  • QA pass is unavailable during an active sprint QA review and disappears after a passing verdict.

Validation

  • pnpm run lint
  • pnpm run test:backend — 437 files passed, 5,490 tests passed, 7 skipped
  • pnpm run test:dashboard — 241 files passed, 2,152 tests passed, 2 skipped
  • pnpm run build
  • Dashboard /sprints returned HTTP 200 on port 4444

Risk and rollback

Risk is limited to explicit manual sprint actions. Runtime cleanup is fail-closed: if active-run cancellation fails, completion is not persisted. Roll back by reverting this commit, which restores the previous generic status patch and removes the manual QA endpoint/action.

@numnx
numnx marked this pull request as ready for review July 13, 2026 03:20
@numnx
numnx merged commit 166cebd into dev Jul 13, 2026
40 checks passed
@numnx
numnx deleted the fix/sprint-completion-and-qa-pass branch July 13, 2026 03:20
@numnx numnx mentioned this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant