fix: repair sprint completion and add QA pass - #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Mark Completedwith a runtime-aware manual completion endpoint.Mark QA Passto sprint card and ledger action menus, including pending, active-review, and already-passed states.Why
The previous completion button changed only the sprint record. When a sprint run was still active, its runtime projection could immediately overwrite the manual
completedstatus, making the button appear broken. Manual QA acceptance also had no sprint-page control or durable QA verdict.User impact
Mark Completednow safely stops active sprint runtime work before persisting completion, so the state remains stable.Mark QA Passrecords an explicit manual pass after human review without dismissing task QA or unrelated attention.Validation
pnpm run lintpnpm run test:backend— 437 files passed, 5,490 tests passed, 7 skippedpnpm run test:dashboard— 241 files passed, 2,152 tests passed, 2 skippedpnpm run build/sprintsreturned HTTP 200 on port 4444Risk and rollback
Risk is limited to explicit manual sprint actions. Runtime cleanup is fail-closed: if active-run cancellation fails, completion is not persisted. Roll back by reverting this commit, which restores the previous generic status patch and removes the manual QA endpoint/action.