fix: honor route thinking settings - #3026
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
maxandultra, while other Codex models remain capped atxhigh.Why
Route Mapping correctly persisted the selected model and thinking value, but the virtual planning path forwarded the resolved model without forwarding the resolved thinking mode. Planning therefore ran with the provider default despite the saved override. The settings UI also lacked Sol-specific reasoning levels and did not retain its focused navigation context after a hard refresh.
User impact
Planning overrides such as Codex
xhighnow reach both the initial planning call and structured retries. Sol-family Codex routes exposemaxandultra, and a refreshed Settings page returns to the same category, Route Mapping card, and invocation route in the current tab.Validation
pnpm run ci— passed/healthreported all componentsUP; Settings route loaded successfullyRisk and rollback
Risk is limited to model-aware thinking validation/normalization and same-tab Settings navigation state. Unsupported reasoning values continue to normalize to the provider default. Roll back by reverting commit
f9f54ea3d.