Skip to content

(CODUX-221) Clarify QA changes-requested presentation - #3041

Merged
numnx merged 1 commit into
feature/CODUX-221-clarify-qa-follow-ups-and-ci-statusfrom
task/feature-codux-22-t03-codex-b0a2f700-mrjm8rn6
Jul 13, 2026
Merged

(CODUX-221) Clarify QA changes-requested presentation#3041
numnx merged 1 commit into
feature/CODUX-221-clarify-qa-follow-ups-and-ci-statusfrom
task/feature-codux-22-t03-codex-b0a2f700-mrjm8rn6

Conversation

@numnx

@numnx numnx commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

🧩 Task: Clarify QA changes-requested presentation

Automated task PR opened by Code UX for T03.

📋 Summary

Sprint: Sprint 221 · Clarify QA follow-ups and CI status · Task: T03

Clarify QA change requests and CI progress consistently across Sprint, Task, and Live cards by projecting complete QA follow-up metadata, deriving durable CI workflow states from existing execution evidence, and presenting accessible, responsive badges with end-to-end regression coverage and synchronized documentation.

🤖 Model & Provider

Provider Codex CLI
Model gpt-5.6-sol

⏱️ Timing

Started 2026-07-13 19:29:01 UTC
Finished 2026-07-13 19:43:53 UTC
Duration 14m 52s

📊 Token Usage

Metric Value
Input tokens 331,202
Cached input tokens 8,336,128
Output tokens 31,418
Total tokens 8,698,748
Invocations 1
Tool calls 76
Active time 14m 10s

Included usage estimate (subscription/local login): $6.77

✅ QA Review

⏳ QA review runs after this PR is opened. Check the task card in the dashboard for the outcome once it lands.

📝 Full Task Prompt
## Objective
Render `changes_requested` reviews as a blue edit-state QA badge whose accessible details card explains the request and keeps generated follow-up task specifications collapsed until opened.

## Scope
- Edit `dashboard/src/v2/components/sprints/SprintReviewBadge.tsx`
- Edit `dashboard/src/v2/hooks/project-resource-utils.ts`
- Edit `dashboard/src/v2/lib/view-models.ts`
- Edit `tests/dashboard/v2/components/sprints/SprintReviewBadge.test.tsx`
- Edit `tests/dashboard/lib/project-resource-utils.test.ts`
- Verify `tests/dashboard/v2/task-row-qa-review.test.tsx` and `tests/dashboard/v2/components/ui/live-task-card.test.tsx`
- Consume the shared QA summary contract introduced by T01

## Implementation Requirements
1. Give `changes_requested` a distinct blue QA treatment with a Lucide edit icon such as `PencilLine`, while preserving green pass, running progress, and red provider-failure states.
2. Replace the current interactive-tooltip pattern with an accessible hover-and-focus details card whose trigger is a button and supports pointer hover, keyboard activation, focus retention, Escape and outside dismissal, touch interaction, viewport-aware positioning, and appropriate ARIA state.
3. Present the review summary, findings, fix instructions, target task key, and reviewer context using concise labels without relying on color or hover alone.
4. Render each follow-up task specification in a native or equivalent accessible disclosure that is collapsed initially and reveals its title, description, priority, dependencies, and prompt content only when expanded.
5. Extend resource and view-model equality checks to include all new QA fields so realtime updates are not discarded, including nested follow-up task changes and sprint `latestReview` changes.
6. Add tests for every review state, keyboard and pointer access, dismissal, initial collapsed state, expansion, long content, missing optional data, accessible names, and cache invalidation.

## Constraints
- Preserve the existing exported component API where practical and do not duplicate QA state mapping in consumers.
- Do not place focusable disclosure controls inside a `role=tooltip`; use semantics suitable for interactive content.
- Keep the card usable at mobile widths and prevent clipping at viewport edges.
- Honor reduced-motion preferences and existing design tokens; do not add dependencies.
- Do not edit Tasks, Live, or Sprints page integration files owned by T04 through T06, or documentation owned by T08.

## Verification
- Run `pnpm exec vitest run tests/dashboard/v2/components/sprints/SprintReviewBadge.test.tsx tests/dashboard/lib/project-resource-utils.test.ts tests/dashboard/v2/task-row-qa-review.test.tsx tests/dashboard/v2/components/ui/live-task-card.test.tsx`.
- Run `pnpm run lint`, `pnpm run test:dashboard`, and `pnpm run build`.
- Confirm a requested-change review is announced as QA changes requested, exposes complete details without mouse-only interaction, and leaves follow-up tasks collapsed until explicitly expanded.
🌿 Branch Info

Base: feature/CODUX-221-clarify-qa-follow-ups-and-ci-status
Head: task/feature-codux-22-t03-codex-b0a2f700-mrjm8rn6


🤖 Generated by Code UX

@numnx
numnx merged commit 241a8fb into feature/CODUX-221-clarify-qa-follow-ups-and-ci-status Jul 13, 2026
20 checks passed
@numnx
numnx deleted the task/feature-codux-22-t03-codex-b0a2f700-mrjm8rn6 branch July 13, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant