fix: terminate Electron startup smoke reliably - #3145
Merged
Conversation
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before-quitserver-drain path unchangedWhy
The macOS release-candidate app successfully started its packaged backend and renderer and wrote the expected readiness marker, but remained alive after
app.exit(0). The native smoke harness therefore timed out despite a healthy installation. This makes the probe exit deterministic without weakening the startup validation.Validation
pnpm exec vitest run tests/backend/electron/startup-smoke.test.ts tests/backend/electron-builder-config.test.ts— 10 passedpnpm run typecheck— passedpnpm run test:backend— 6,149 passed, 12 skippedpnpm run build— passedgit diff --check— passedRisk / rollback
Risk is limited to the opt-in installed-app smoke environment. Production desktop shutdown behavior is unchanged. Roll back commit
2ad49c415if a runner-specific regression appears.