fix: harden Windows installer smoke recovery - #3151
Merged
Merged
Conversation
Collaborator
Author
|
The first manual native diagnostic exposed an additional workflow defect before the installed-app step: trailing |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0xC0000005termination with bounded 1.5s, 5s, and 15s backoffWhy
The final
0.9.10release candidate produced a valid Windows installer, but GitHub runner host inspection terminated the installer twice immediately after packaging. A preceding green run recovered from the same status on its second attempt, showing that the previous single quick retry was too narrow for this runner-level transient.Validation
node_modules/.bin/vitest run tests/backend/electron-builder-config.test.ts tests/backend/ci/workflow-health.test.ts(20 passed)node_modules/.bin/tsc --noEmit --incremental --tsBuildInfoFile .cache/tsc/root.tsbuildinfonode scripts/build.mjsnode scripts/sync-docs-web.mjs --checknode --check scripts/smoke-installed-electron.mjsThe direct project binaries were used locally because the existing pnpm wrapper stops on the unrelated local
electron-winstallerbuild-approval state. CI installs from a clean environment and remains authoritative.Risk / rollback
Low risk: recovery is limited to the exact observed access-violation status and adds at most 21.5 seconds before a definitive failure. Revert this PR to restore the previous two-attempt behavior.