Skip to content

fix: stabilize silent Windows installer smoke - #3153

Merged
numnx merged 1 commit into
devfrom
fix/windows-silent-installer-crash
Jul 16, 2026
Merged

fix: stabilize silent Windows installer smoke#3153
numnx merged 1 commit into
devfrom
fix/windows-silent-installer-crash

Conversation

@numnx

@numnx numnx commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • skip the custom NSIS beta page before nsDialogs initializes during silent installs
  • explicitly select current-user mode in the isolated Windows installed-app smoke
  • preserve the existing bounded retry policy for the exact transient access-violation status
  • document the interactive and non-interactive installer behavior

Why

The Windows release-candidate installer could terminate with 0xC0000005 on every retry before the packaged application started. The custom page had no silent-mode guard, so non-interactive release and deployment installs could enter UI plugin initialization without an interactive desktop.

Validation

  • node_modules/.bin/vitest run tests/backend/electron-builder-config.test.ts — 7 passed
  • node_modules/.bin/vitest run tests/backend — 6,151 passed, 12 skipped
  • node_modules/.bin/tsc --noEmit --pretty false — passed
  • node scripts/build.mjs — passed
  • Electron Builder reached Windows packaging locally; native completion requires Wine and is validated by the Windows CI runner

Risk and rollback

Interactive installers still show the beta notice. Silent installs skip only that custom page and continue through the standard NSIS installation flow. Roll back this commit to restore the previous page behavior.

@numnx
numnx merged commit 5ab4905 into dev Jul 16, 2026
43 checks passed
@numnx
numnx deleted the fix/windows-silent-installer-crash branch July 16, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant