fix: harden Windows installer and dependency toolchain - #3156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
windows-latestfor every Windows lane.tslib, validating packaged runtime imports, and preserving direct runtime dependencies includingzod.Why
The Windows per-user NSIS installer could terminate with
0xC0000005, and pnpm 11's stricter dependency layout exposed packages that were previously available only through incidental hoisting, including the installed desktopzodfailure. The release pipeline also retried the Windows crash, which could hide a broken first installation attempt.After the initial toolchain upgrade, native Windows packaging exposed a second integration issue: Electron Builder and NSIS both searched the same standard plugin directory, so
makensisrejected duplicatensDialogsandSystemcommands. The final configuration keeps NSIS 3.12 as the compiler and standard-plugin source while loading only Electron Builder's additional plugins from a separate checksum-pinned archive.Validation
pnpm run ci— passedpnpm run test:e2e— 74 passedpnpm run test:orchestration:rapid— 292 passed, 7 skippedpnpm run test:orchestration:ci-dag— passed with four merged tasks, QA follow-up repair, two forced runtime restarts, and complete workspace cleanup.deb.debpackaged-app startup smoke — renderer-ready and clean exitwindows-latest): NSIS package, first-attempt install, and installed-app launch passedRisk and rollback
This intentionally includes the compatible dependency refresh needed for the 0.9.10 toolchain, including Electron and native ONNX updates. The final three-OS native package/install/start gate passed on commit
b28774140e925186536c2359e929afd827ea7cc5. Rollback is a revert of this PR; no database or persistent-state migration is included.