fix: harden restart QA DAG assertions - #3159
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The Linux Docker DAG completed successfully through two forced runtime restarts, but CI rejected the valid QA history
changes_requested → changes_requested → pass. A restart had recovered a completed follow-up invocation before its workspace repair was visible, so QA correctly requested the same change again before the next repair succeeded.The previous test harness assumed exactly one rejection. This change recognizes that valid recovery path without weakening detection of genuine orchestration errors.
Validation
pnpm exec vitest run tests/backend/scripts/mockup-sprint-pentest-runner.test.ts tests/backend/ci/workflow-health.test.ts— 46 passedpnpm run lint— passedpnpm run check:docs-web— passedpnpm run ci— passedRisk and rollback
Risk is limited to the mockup orchestration test harness and its documentation; production orchestration behavior is unchanged. Roll back commit
901c2ab5bif the stricter causal matching causes an unexpected test-only regression.