fix: recover Codex QA follow-ups without rollout - #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
thread/resumefailures that specifically reportno rollout found for thread idfrom structured provider errors or stderr.Why
Task QA can request a coding follow-up after a task completes. The handoff correctly retained the coding session and workspace, but a persisted Codex native thread ID could outlive its workspace-local rollout. Codex then rejected
thread/resume, causing the Task Coding invocation to fail before applying the QA fixes.The QA follow-up prompt is self-contained with the original subtask and concrete QA instructions, so retrying only the provider conversation while retaining the workspace safely recovers this missing-runtime-artifact case.
User impact
A single-task QA review that requests changes no longer fails solely because Codex cannot find the persisted rollout. The task stays in its QA handoff, keeps its code/worktree, and receives one bounded fresh-session retry. Unrelated Codex failures remain visible and are not retried by this path.
Validation
pnpm run lint— passedpnpm run test:backend— passed (467 files; 6,163 passed, 12 skipped)pnpm run build— passedgit diff --check— passedRisk and rollback
Risk is limited to the exact Codex missing-rollout error during explicitly opted-in continuations. The retry is bounded to one attempt and preserves the existing workspace. Roll back commit
ee81177d8to restore the prior fail-closed behavior.