Fix classic loading spinner preview in editor #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the paged entry type was extracted, the editor used the same layout as the published entries. Once the paged entries used their own layout [1], the editor got a separate layout [2] and everything related to Paged was removed [3]. We missed that the loading spinner inline script was also needed inside the editor to ensure the preview could be displayed. Add it back to the paged head editor partial. We also could have added the rule to an editor stylesheet, but that would have meant introducing a third place where loading spinner display is controlled. This way editor and published entry work the same way. REDMINE-17738 [1] codevise@b076267#diff-d6c740536eb9bfa6732ef7dfa73df647cae865b6d4a0f7d48ea309ded4c745aa [2] codevise@1ee34a9#diff-bf899f40e327b5be0b920c45d6a8602eddfbd0bdbf90e1cdd312c696cec13ec9 [3] codevise@e83409d#diff-bf899f40e327b5be0b920c45d6a8602eddfbd0bdbf90e1cdd312c696cec13ec9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the paged entry type was extracted, the editor used the same
layout as the published entries. Once the paged entries used their own
layout [1], the editor got a separate layout [2] and everything
related to Paged was removed [3]. We missed that the loading spinner
inline script was also needed inside the editor to ensure the preview
could be displayed. Add it back to the paged head editor partial.
We also could have added the rule to an editor stylesheet, but that
would have meant introducing a third place where loading spinner
display is controlled. This way editor and published entry work the
same way.
REDMINE-17738
[1] b076267#diff-d6c740536eb9bfa6732ef7dfa73df647cae865b6d4a0f7d48ea309ded4c745aa
[2] 1ee34a9#diff-bf899f40e327b5be0b920c45d6a8602eddfbd0bdbf90e1cdd312c696cec13ec9
[3] e83409d#diff-bf899f40e327b5be0b920c45d6a8602eddfbd0bdbf90e1cdd312c696cec13ec9