Support declaring font faces in theme options - #2459
Merged
Conversation
Loading custom fonts required referencing a stylesheet pack, which means a code deploy per font and an extra stylesheet request before the browser can start downloading font files. Font faces can now be declared in theme options instead, pointing either at files in the theme's asset directory or at uploaded theme customization files. The latter prepares letting admins upload fonts in site settings. Loading fonts via stylesheet packs keeps working unchanged. REDMINE-21330
Resolving a path in the shared theme directory stripped the prefix from the string it was given. Callers passing the same string object more than once - like theme options declaring font faces - got the wrong directory on every render after the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21330