v0.4.0: Intel-powered scanning — fail-loud data handling, signed compressed snapshots, mirrors - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/defaultsandtemplater/templates; both moved underinternal/and arego:embed-ed, soBuildKit failed on missing sources. Removed, along with the now-wrong
ENV CODEWARD_TEMPLATES_PATH— that variable is an override, not a default.dev(§1.2). Neither the Dockerfile norbuild-binaries.yamlinjected the version ldflags, somain.Version— whichis forwarded into every Intel query as
ScannerVersionand into contributionattribution — made every scanner in the world look like the same unreleased
build. Now injected in both, plus
git describein the Makefile.go.modcommitted areplaceto../codeward-common— not in the plan.A clean single-repo checkout, which is exactly what the Docker build and
build-binaries.yamldo, failed module resolution before compiling a line.No release artifact could have been produced. Removed and pinned.
snapshot path (downloading, not cache-only — the query endpoint and the static
segment endpoints fail independently). Adds
scanner.IntelStatuscarryingsource/degraded/reason/watermark,
--intel-required(default true), awarning banner in PR comments, and 429 +
Retry-Afterhandling.path, the caller answered that error by falling through to a legacy downloader
with no signature check, against the same host. Anyone able to serve a bad
manifest could get their database trusted by failing verification on purpose.
The legacy
OfflineDBpath is deleted (§1.7).CODEWARD_CACHE_DIRunset it resolved to the relative
intel-snapshots; in the container that is/, which the scan user cannot write. The documented-v ...:/tmp/.cachemount and the action's cache step were both writing where nothing read. Found
by running the image.
reflectbecause SQLite wanted lock state beside a file it could not write andreturned malformed rows.
immutable=1on the DSN;:rois the documentedair-gapped setup.