fix(types): fix typescript compiler errors under strict mode#2210
Closed
rajwilkhu wants to merge 1 commit intocodex-team:nextfrom
Closed
fix(types): fix typescript compiler errors under strict mode#2210rajwilkhu wants to merge 1 commit intocodex-team:nextfrom
rajwilkhu wants to merge 1 commit intocodex-team:nextfrom
Conversation
rajwilkhu
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
Author
|
@here, any way to get this reviewed? It's a minor change? @neSpecc @gohabereg @TatianaFomina @ilyamore88 |
Member
|
I think it is not the only error under strict mode. We should enable it in our tsconfig and fix all errors complexly. |
Member
|
But we can accept your change and release a patch anyway if your work relies on this. |
Member
|
Could you add a changelog, please? |
|
@neSpecc please merge this PR asap this issue is breaking our prod, even the --skipLibCheck has no effect on the .ts files , we have to disbale typecheck for the entire project which is bad ! |
Member
|
Thanks for the fix. Unfortunately, I was not able to push to your branch due to disabled access for maintainers. So I'm focusing on the similar PR #2264 and closing this PR as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is relate to issue #2209