fix(types): compiler error from importing type BlockToolData#2264
Merged
neSpecc merged 9 commits intocodex-team:nextfrom Feb 20, 2023
Merged
fix(types): compiler error from importing type BlockToolData#2264neSpecc merged 9 commits intocodex-team:nextfrom
neSpecc merged 9 commits intocodex-team:nextfrom
Conversation
vite v4.0.4 building for production...
node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues'
1 import {BlockToolData} from '../tools';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:9 - error TS1444: 'BlockToolData' is a type and must be imported using a type-only import when 'preserveValueImports' and 'isolatedModules' are both enabled.
1 import {BlockToolData} from '../tools';
neSpecc
approved these changes
Feb 20, 2023
TatianaFomina
approved these changes
Feb 20, 2023
Member
|
Thanks @arkamali and @TatianaFomina |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2209