Skip to content

fix(js): trim source code lines#188

Merged
neSpecc merged 3 commits intomasterfrom
chore-js-line-trimming
Feb 26, 2021
Merged

fix(js): trim source code lines#188
neSpecc merged 3 commits intomasterfrom
chore-js-line-trimming

Conversation

@neSpecc
Copy link
Copy Markdown
Member

@neSpecc neSpecc commented Feb 19, 2021

We want to prevent a memory leak from storing long source code lines:

image

Comment thread lib/utils/string.ts Outdated
neSpecc and others added 2 commits February 19, 2021 20:54
Co-authored-by: Taly <vitalik7tv@yandex.ru>
@neSpecc neSpecc merged commit 7e97edc into master Feb 26, 2021
@neSpecc neSpecc deleted the chore-js-line-trimming branch February 26, 2021 19:07
nikmel2803 added a commit that referenced this pull request Feb 27, 2021
* Check workspace event (#184)

* add definitions for limiter worker event types

* some code refactoring

* refactor logger creating logic

* refactor limiter worker and add second event type handler

* fix error if no workspace with provided id were found

* update docs

* fixes

* update docs

* fix linter errors

* add tests

* fix docs

* fix README.md

* upgrade eslint config codex (#187)

* [Feature] Paymaster checks subscription (#186)

* update hawk.types

* refactor paymaster worker

* fix lint warnings

* update hawk.types

* add tests for paymaster worker

* remove unused envs

* update README.md

* [Feature] Cache in grouper (#170)

* save changes

* memoize hashing

* update

* init cache

* fix eslint

* add missing await and async

* add missing async

* add clearCache method

* add type to query field, use JSON.stringify

* rewrite doc

* fix doc

* move clearCache to abstract worker

Co-authored-by: ilyamore88 <themorozik@gmail.com>

* fix(js): trim source code lines (#188)

* fix(js): trim source code lines

* Update string.ts

* Update lib/utils/string.ts

Co-authored-by: Taly <vitalik7tv@yandex.ru>

Co-authored-by: Taly <vitalik7tv@yandex.ru>

Co-authored-by: Nikita Melnikov <nikmel2803@gmail.com>
Co-authored-by: Murod Khaydarov <murod.haydarov@gmail.com>
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
Co-authored-by: Taly <vitalik7tv@yandex.ru>
ilyamore88 added a commit that referenced this pull request Mar 1, 2021
* Check workspace event (#184)

* add definitions for limiter worker event types

* some code refactoring

* refactor logger creating logic

* refactor limiter worker and add second event type handler

* fix error if no workspace with provided id were found

* update docs

* fixes

* update docs

* fix linter errors

* add tests

* fix docs

* fix README.md

* upgrade eslint config codex (#187)

* [Feature] Paymaster checks subscription (#186)

* update hawk.types

* refactor paymaster worker

* fix lint warnings

* update hawk.types

* add tests for paymaster worker

* remove unused envs

* update README.md

* [Feature] Cache in grouper (#170)

* save changes

* memoize hashing

* update

* init cache

* fix eslint

* add missing await and async

* add missing async

* add clearCache method

* add type to query field, use JSON.stringify

* rewrite doc

* fix doc

* move clearCache to abstract worker

Co-authored-by: ilyamore88 <themorozik@gmail.com>

* fix(js): trim source code lines (#188)

* fix(js): trim source code lines

* Update string.ts

* Update lib/utils/string.ts

Co-authored-by: Taly <vitalik7tv@yandex.ru>

Co-authored-by: Taly <vitalik7tv@yandex.ru>

* [Feature] Block workspace message in sender worker (#191)

* fix warning

* add types for block workspace message

* add some docs

* add logic for block workspace message

* fix import and type

* fix review comments

* send messages only to admins

* Metrics optimization (#193)

* optimize push time 1s -> 10s
* unhardcode push time -> .env
* `push` -> `pushAdd`

Co-authored-by: Nikita Melnikov <nikmel2803@gmail.com>
Co-authored-by: Murod Khaydarov <murod.haydarov@gmail.com>
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
Co-authored-by: Taly <vitalik7tv@yandex.ru>
Co-authored-by: Danil Beltyukov <beltyukovdanil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants