Merged
Conversation
|
This pull request introduces 1 alert when merging 138f487 into e0dd29c - view on LGTM.com new alerts:
|
…nto grouper-cache
|
This pull request introduces 1 alert when merging 601aa13 into 8a36ec8 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 457fb16 into 8a36ec8 - view on LGTM.com new alerts:
|
neSpecc
reviewed
Dec 14, 2020
| /** | ||
| * Memoized Hashing computation | ||
| */ | ||
| private static cachedHashValues: {[key: string]: string} = {}; |
Member
There was a problem hiding this comment.
не понятное название и описание: что за хэш, для чего memorized
| } | ||
|
|
||
| try { | ||
| const eventCacheKey = `${projectId}:${query.toString()}`; |
Member
There was a problem hiding this comment.
а какой тип у query? если объект, то почему не JSON.stringify?
neSpecc
approved these changes
Dec 19, 2020
nikmel2803
reviewed
Dec 19, 2020
| /** | ||
| * Forced clears worker cache | ||
| */ | ||
| public clearCache(): void { |
Member
There was a problem hiding this comment.
не логичнее это впихнуть в абстрактного воркера?
| public readonly type: string = pkg.workerType; | ||
|
|
||
| /** | ||
| * Contains hashed events by his catcher type and event title as keys |
Member
There was a problem hiding this comment.
судя по примеру, там не ивент содержится, а его групхэш
и смущает his, может надо its?
…nto grouper-cache
…nto grouper-cache
talyguryn
approved these changes
Feb 5, 2021
…nto grouper-cache
nikmel2803
approved these changes
Feb 25, 2021
nikmel2803
added a commit
that referenced
this pull request
Feb 27, 2021
* Check workspace event (#184) * add definitions for limiter worker event types * some code refactoring * refactor logger creating logic * refactor limiter worker and add second event type handler * fix error if no workspace with provided id were found * update docs * fixes * update docs * fix linter errors * add tests * fix docs * fix README.md * upgrade eslint config codex (#187) * [Feature] Paymaster checks subscription (#186) * update hawk.types * refactor paymaster worker * fix lint warnings * update hawk.types * add tests for paymaster worker * remove unused envs * update README.md * [Feature] Cache in grouper (#170) * save changes * memoize hashing * update * init cache * fix eslint * add missing await and async * add missing async * add clearCache method * add type to query field, use JSON.stringify * rewrite doc * fix doc * move clearCache to abstract worker Co-authored-by: ilyamore88 <themorozik@gmail.com> * fix(js): trim source code lines (#188) * fix(js): trim source code lines * Update string.ts * Update lib/utils/string.ts Co-authored-by: Taly <vitalik7tv@yandex.ru> Co-authored-by: Taly <vitalik7tv@yandex.ru> Co-authored-by: Nikita Melnikov <nikmel2803@gmail.com> Co-authored-by: Murod Khaydarov <murod.haydarov@gmail.com> Co-authored-by: Peter Savchenko <specc.dev@gmail.com> Co-authored-by: Taly <vitalik7tv@yandex.ru>
ilyamore88
added a commit
that referenced
this pull request
Mar 1, 2021
* Check workspace event (#184) * add definitions for limiter worker event types * some code refactoring * refactor logger creating logic * refactor limiter worker and add second event type handler * fix error if no workspace with provided id were found * update docs * fixes * update docs * fix linter errors * add tests * fix docs * fix README.md * upgrade eslint config codex (#187) * [Feature] Paymaster checks subscription (#186) * update hawk.types * refactor paymaster worker * fix lint warnings * update hawk.types * add tests for paymaster worker * remove unused envs * update README.md * [Feature] Cache in grouper (#170) * save changes * memoize hashing * update * init cache * fix eslint * add missing await and async * add missing async * add clearCache method * add type to query field, use JSON.stringify * rewrite doc * fix doc * move clearCache to abstract worker Co-authored-by: ilyamore88 <themorozik@gmail.com> * fix(js): trim source code lines (#188) * fix(js): trim source code lines * Update string.ts * Update lib/utils/string.ts Co-authored-by: Taly <vitalik7tv@yandex.ru> Co-authored-by: Taly <vitalik7tv@yandex.ru> * [Feature] Block workspace message in sender worker (#191) * fix warning * add types for block workspace message * add some docs * add logic for block workspace message * fix import and type * fix review comments * send messages only to admins * Metrics optimization (#193) * optimize push time 1s -> 10s * unhardcode push time -> .env * `push` -> `pushAdd` Co-authored-by: Nikita Melnikov <nikmel2803@gmail.com> Co-authored-by: Murod Khaydarov <murod.haydarov@gmail.com> Co-authored-by: Peter Savchenko <specc.dev@gmail.com> Co-authored-by: Taly <vitalik7tv@yandex.ru> Co-authored-by: Danil Beltyukov <beltyukovdanil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds cache usage to grouper worker.