Trim event title to a maximum length in grouper#574
Merged
Conversation
neSpecc
reviewed
Jul 1, 2026
neSpecc
reviewed
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds event-title trimming in the Grouper worker pipeline to cap excessively long titles (keeping hashing and stored payload consistent) and adds a regression test to validate the trimming behavior.
Changes:
- Add
DataFilter.trimEventTitle()to trimevent.titleto 1000 characters (plus an ellipsis when trimmed). - Invoke title trimming during
GrouperWorker.handleInternal()before unique-hash calculation. - Add a unit test ensuring long titles are trimmed before persisting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workers/grouper/tests/index.test.ts | Adds coverage asserting long titles are truncated and end with an ellipsis. |
| workers/grouper/src/index.ts | Calls title trimming prior to computing the event’s unique hash (and affects downstream grouping/saving). |
| workers/grouper/src/data-filter.ts | Introduces title-trimming logic in DataFilter using the shared rightTrim() helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
reviewed
Jul 8, 2026
neSpecc
reviewed
Jul 8, 2026
neSpecc
previously approved these changes
Jul 13, 2026
neSpecc
reviewed
Jul 21, 2026
neSpecc
reviewed
Jul 21, 2026
neSpecc
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
workers/grouper/src/data-filter.ts:15
- PR description says the event title should be trimmed to 1000 chars, but this implementation uses MAX_TITLE_LENGTH = 400 (and the tests expect 401 including the ellipsis from rightTrim). Since the grouping hash is derived from
task.payload.title, a lower-than-intended cap increases the chance of unrelated events collapsing into the same group. Please align the limit (and corresponding tests/PR description) to the intended maximum.
/**
* Maximum length for event title before appending ellipsis
*/
const MAX_TITLE_LENGTH = 400;
workers/grouper/src/index.ts:212
- This comment is slightly misleading: the grouping hash is computed only from
catcherType + task.payload.title, so the key reason to run DataFilter here is to ensure title trimming happens before hashing. Consider rewording to avoid implying other payload fields affect the hash.
/**
* Filter event data before hashing so hash and stored event stay consistent.
*/
Kuchizu
added a commit
that referenced
this pull request
Jul 22, 2026
* feat(grouper): add slow handle diagnostics (#549) * feat(grouper): add slow handle diagnostics * refactor(grouper): extract slow handle diagnostics into session * fix(grouper): use monotonic time and exclusive timings in slow handle diagnostics * fix(db): retry initial Mongo connection to avoid worker crash-loop (#559) * fix(db): retry initial Mongo connection to avoid worker crash-loop * fix(db): clamp Mongo reconnect env vars and test retry loop * refactor(db): move positiveIntEnv to utils * fix(task-manager): use event._id instead of groupHash in issue event URL (#569) * Initial plan * fix: use event._id instead of groupHash in task-manager event URL --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * fix(limiter): handle workspace without tariffPlanId (#571) * fix(limiter): handle workspace without tariffPlanId * fix(limiter): avoid toString on missing tariffPlanId in error message * Await provider.send in sender worker (#577) * Await provider.send in sender worker * test(sender): add test for provider.send rejection handling in worker * Fix appName option and count billing events via dailyEvents (#575) * Fix appName option ignored by mongodb driver 3.x * Count billing events via dailyEvents daily counters * Fix limiter worker tests for boundary-day counting * Add opt-in dailyEvents limiter counter * Compare old and new limiter counters via Telegram log * Trim event title to a maximum length in grouper (#574) * Trim event title to a maximum length in grouper * refactor(grouper): move title trimming into DataFilter * Trim grouper event titles * Add Sanitizer for event payload fields and drop per-event handle log * Keep sanitizer placeholder for context/addons wrapped in object * Update string context test to expect placeholder object * Document string-context sanitize handling * Cut off extra object keys instead of replacing object with placeholder --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Dobrunia Kostrigin <48620984+Dobrunia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims event title to 1000 chars