Skip to content

Trim event title to a maximum length in grouper#574

Merged
neSpecc merged 11 commits into
masterfrom
feat/grouper-limit-event-title
Jul 21, 2026
Merged

Trim event title to a maximum length in grouper#574
neSpecc merged 11 commits into
masterfrom
feat/grouper-limit-event-title

Conversation

@Kuchizu

@Kuchizu Kuchizu commented Jul 1, 2026

Copy link
Copy Markdown
Member

Trims event title to 1000 chars

Comment thread workers/grouper/src/index.ts Outdated
Comment thread workers/grouper/src/data-filter.ts Outdated
Comment thread workers/grouper/src/index.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds event-title trimming in the Grouper worker pipeline to cap excessively long titles (keeping hashing and stored payload consistent) and adds a regression test to validate the trimming behavior.

Changes:

  • Add DataFilter.trimEventTitle() to trim event.title to 1000 characters (plus an ellipsis when trimmed).
  • Invoke title trimming during GrouperWorker.handleInternal() before unique-hash calculation.
  • Add a unit test ensuring long titles are trimmed before persisting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
workers/grouper/tests/index.test.ts Adds coverage asserting long titles are truncated and end with an ellipsis.
workers/grouper/src/index.ts Calls title trimming prior to computing the event’s unique hash (and affects downstream grouping/saving).
workers/grouper/src/data-filter.ts Introduces title-trimming logic in DataFilter using the shared rightTrim() helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread workers/grouper/src/index.ts Outdated
Comment thread workers/grouper/src/data-filter.ts Outdated
Comment thread workers/grouper/src/index.ts Outdated
Comment thread workers/grouper/src/data-filter.ts
neSpecc
neSpecc previously approved these changes Jul 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread workers/grouper/src/data-filter.ts
Comment thread workers/grouper/src/data-filter.ts
Comment thread workers/grouper/src/index.ts
Comment thread workers/grouper/src/data-filter.ts Outdated
Comment thread workers/grouper/tests/index.test.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

workers/grouper/src/data-filter.ts:15

  • PR description says the event title should be trimmed to 1000 chars, but this implementation uses MAX_TITLE_LENGTH = 400 (and the tests expect 401 including the ellipsis from rightTrim). Since the grouping hash is derived from task.payload.title, a lower-than-intended cap increases the chance of unrelated events collapsing into the same group. Please align the limit (and corresponding tests/PR description) to the intended maximum.
/**
 * Maximum length for event title before appending ellipsis
 */
const MAX_TITLE_LENGTH = 400;

workers/grouper/src/index.ts:212

  • This comment is slightly misleading: the grouping hash is computed only from catcherType + task.payload.title, so the key reason to run DataFilter here is to ensure title trimming happens before hashing. Consider rewording to avoid implying other payload fields affect the hash.
    /**
     * Filter event data before hashing so hash and stored event stay consistent.
     */

@neSpecc
neSpecc merged commit 541251f into master Jul 21, 2026
6 checks passed
@neSpecc
neSpecc deleted the feat/grouper-limit-event-title branch July 21, 2026 19:01
Kuchizu added a commit that referenced this pull request Jul 22, 2026
* feat(grouper): add slow handle diagnostics (#549)

* feat(grouper): add slow handle diagnostics

* refactor(grouper): extract slow handle diagnostics into session

* fix(grouper): use monotonic time and exclusive timings in slow handle diagnostics

* fix(db): retry initial Mongo connection to avoid worker crash-loop (#559)

* fix(db): retry initial Mongo connection to avoid worker crash-loop

* fix(db): clamp Mongo reconnect env vars and test retry loop

* refactor(db): move positiveIntEnv to utils

* fix(task-manager): use event._id instead of groupHash in issue event URL (#569)

* Initial plan

* fix: use event._id instead of groupHash in task-manager event URL

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* fix(limiter): handle workspace without tariffPlanId (#571)

* fix(limiter): handle workspace without tariffPlanId

* fix(limiter): avoid toString on missing tariffPlanId in error message

* Await provider.send in sender worker (#577)

* Await provider.send in sender worker

* test(sender): add test for provider.send rejection handling in worker

* Fix appName option and count billing events via dailyEvents (#575)

* Fix appName option ignored by mongodb driver 3.x

* Count billing events via dailyEvents daily counters

* Fix limiter worker tests for boundary-day counting

* Add opt-in dailyEvents limiter counter

* Compare old and new limiter counters via Telegram log

* Trim event title to a maximum length in grouper (#574)

* Trim event title to a maximum length in grouper

* refactor(grouper): move title trimming into DataFilter

* Trim grouper event titles

* Add Sanitizer for event payload fields and drop per-event handle log

* Keep sanitizer placeholder for context/addons wrapped in object

* Update string context test to expect placeholder object

* Document string-context sanitize handling

* Cut off extra object keys instead of replacing object with placeholder

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Dobrunia Kostrigin <48620984+Dobrunia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants