feat(otel-nestjs-instrumentation): extract shared startOtelInstrumentationIfAbsent function - #9
Merged
Conversation
…ationIfAbsent function - Create src/start-otel-instrumentation-if-absent.ts mirroring the newrelic-nestjs-instrumentation pattern (startNewRelicTransactionIfAbsent) - Update OtelContextGuard to delegate to the shared function instead of inline span-check logic - Update OtelInterceptor to call startOtelInstrumentationIfAbsent as a fallback for RPC contexts where no HTTP guard has run - Export from src/index.ts and internal/index.ts - Update all affected tests (guard, interceptor, integration) to match the new architecture
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the
newrelic-nestjs-instrumentationpattern by extracting a sharedstartOtelInstrumentationIfAbsentfunction that bothOtelContextGuardandOtelInterceptordelegate to.Changes
src/start-otel-instrumentation-if-absent.ts— checks for an existing span viaInternalContext.getSpan()before creating a new one, preventing duplicate spansOtelContextGuard— now delegates to the shared function instead of inline span-check logicOtelInterceptor— calls the shared function as a fallback for RPC contexts where no HTTP guard has run (guard-only works for HTTP requests; interceptor is the RPC fallback)src/index.tsandsrc/internal/index.tsWhy this pattern?
The guard only runs for HTTP requests, while the interceptor also handles RPC. Both need to start instrumentation if none exists — a shared function avoids duplication and ensures consistent behavior across request types.
Verification