DDF-5635: Attach dependency check report to build. by AdamBurstynski · Pull Request #5643 · codice/ddf

AdamBurstynski · 2019-11-27T18:59:02Z

What does this PR do?

Archive the dependency-check aggregate report after the owasp stage finishes successfully

Who is reviewing it?

@TonyMorrison
@LinkMJB
@shaundmorris

Select relevant component teams:

@codice/build
@codice/security

How should this be tested?

N/A

Any background context you want to provide?

N/A

What are the relevant tickets?

Fixes: #5635

Screenshots

Checklist:

Documentation Updated
Update / Add Threat Dragon models
Update / Add Unit Tests
Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

…nishes.

AdamBurstynski · 2019-11-27T19:04:20Z

build now

cxbot · 2019-11-27T19:07:12Z

Internal build has been scheduled, your results will be available at build completion.

TonyMorrison

Looks good, straight forward

cxbot · 2019-11-27T21:52:11Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/7769/
✅ JOB SUCCESS

shaundmorris · 2019-12-02T22:56:31Z

                    }
+                    post {
+                        success {
+                            archiveArtifacts artifacts: 'target/dependency-check-report.html'


Think this will work with dependency-check or aggregate 👍

LinkMJB · 2019-12-03T19:34:27Z

                    }
+                    post {
+                        success {
+                            archiveArtifacts artifacts: 'target/dependency-check-report.html'


Is there any case that this file won't exist? Wondering if we should include the allowEmptyArchive option

If the stage is successful the file has to exist because the maven goal we call creates the file. If the file does not exist the goal failed and the post block will never be called.

…nishes. (codice#5643) (cherry picked from commit 03a3865)

* Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac)

* Updated Jenkinsfile (#5190) Removed the Xss thread stack size option and added a minimum heap memory option to maven opts (cherry picked from commit e523306) * Increased timeout value to prevent build abortions (need to RCA why builds are taking longer) (cherry picked from commit 68b9232) * DDF-5578 updated codecov stage to be more efficient (#5579) (cherry picked from commit 2e7ec9e) * Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac)

* Updated Jenkinsfile (#5190) Removed the Xss thread stack size option and added a minimum heap memory option to maven opts (cherry picked from commit e523306) * Increased timeout value to prevent build abortions (need to RCA why builds are taking longer) (cherry picked from commit 68b9232) * DDF-5504 Upgraded to DDF-Parent 1.0.8 and Dependency-Check 5.2.2 (#5510) Cleaned-up dependency-check configuration DDF-5504 Updated dependency-check stage to be more efficient DDF-5504 Updated DDF-Parent and Depdendency-Check DDF-5504 Added dependency-check:aggregate to non-PR builds (cherry picked from commit 0456c03) * DDF-5578 updated codecov stage to be more efficient (#5579) (cherry picked from commit 2e7ec9e) * Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac) * DDF-5597 updated dependency-check properties for local NVD (#5654) * DDF-5597 updated dependency-check properties * DDF-5597 added back dependency-check maven version (cherry picked from commit 365bfdd) Co-authored-by: Ryan Zwiefelhofer <rzwiefel@users.noreply.github.com> Co-authored-by: Matthew Bates <matthew.bates@connexta.com> Co-authored-by: Shaun Morris <shaundmorris@users.noreply.github.com>

* DDF-5578 updated codecov stage to be more efficient (#5579) (cherry picked from commit 2e7ec9e) * Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac) * DDF-5597 updated dependency-check properties for local NVD (#5654) * DDF-5597 updated dependency-check properties * DDF-5597 added back dependency-check maven version (cherry picked from commit 365bfdd) Co-authored-by: Shaun Morris <shaundmorris@users.noreply.github.com>

* Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * Updated Jenkinsfile (#5190) Removed the Xss thread stack size option and added a minimum heap memory option to maven opts (cherry picked from commit e523306) * DDF-5578 updated codecov stage to be more efficient (#5579) (cherry picked from commit 2e7ec9e) * Increased timeout value to prevent build abortions (need to RCA why builds are taking longer) (cherry picked from commit 68b9232) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac) * DDF-5504 Upgraded to DDF-Parent 1.0.8 and Dependency-Check 5.2.2 (#5510) Cleaned-up dependency-check configuration DDF-5504 Updated dependency-check stage to be more efficient DDF-5504 Updated DDF-Parent and Depdendency-Check DDF-5504 Added dependency-check:aggregate to non-PR builds (cherry picked from commit 0456c03) (cherry picked from commit 6a48ac2) * DDF-5597 updated dependency-check properties for local NVD (#5654) * DDF-5597 updated dependency-check properties * DDF-5597 added back dependency-check maven version (cherry picked from commit 365bfdd) Co-authored-by: Ryan Zwiefelhofer <rzwiefel@users.noreply.github.com> Co-authored-by: Shaun Morris <shaundmorris@users.noreply.github.com> Co-authored-by: Matthew Bates <matthew.bates@connexta.com>

* DDF-5504 Upgraded to DDF-Parent 1.0.8 and Dependency-Check 5.2.2 (#5510) Cleaned-up dependency-check configuration DDF-5504 Updated dependency-check stage to be more efficient DDF-5504 Updated DDF-Parent and Depdendency-Check DDF-5504 Added dependency-check:aggregate to non-PR builds (cherry picked from commit 0456c03) * DDF-5578 updated codecov stage to be more efficient (#5579) (cherry picked from commit 2e7ec9e) * Increased timeout value to prevent build abortions (need to RCA why builds are taking longer) (cherry picked from commit 68b9232) * Archive the dependecy-check aggregate report after the owasp stage finishes. (#5643) (cherry picked from commit 03a3865) * General Jenkinsfile cleanup. (#5666) Moved Codeco.io to be right after the ITests. Removed all the commented windows sections. Removed unneeded parallel sections as well. Added in Commenting onto PR builds using internal library function postCommetnIfPR. (cherry picked from commit efe40ac) * DDF-5597 updated dependency-check properties for local NVD (#5654) * DDF-5597 updated dependency-check properties * DDF-5597 added back dependency-check maven version (cherry picked from commit 365bfdd) Co-authored-by: Shaun Morris <shaundmorris@users.noreply.github.com> Co-authored-by: Matthew Bates <matthew.bates@connexta.com>

Archive the dependecy-check aggregate report after the owasp stage fi…

d8c95ec

…nishes.

TonyMorrison approved these changes Nov 27, 2019

View reviewed changes

shaundmorris approved these changes Dec 2, 2019

View reviewed changes

LinkMJB approved these changes Dec 3, 2019

View reviewed changes

shaundmorris merged commit 03a3865 into codice:master Dec 4, 2019

AdamBurstynski deleted the archive_owasp_report branch December 4, 2019 15:17

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

17de86e

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

cf73612

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

04590b7

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

184cef1

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

a3a3c1c

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

42acf96

…nishes. (codice#5643) (cherry picked from commit 03a3865)

AdamBurstynski pushed a commit to AdamBurstynski/ddf that referenced this pull request Dec 17, 2019

Archive the dependecy-check aggregate report after the owasp stage fi…

2a2e76d

…nishes. (codice#5643) (cherry picked from commit 03a3865)

jlcsmith added this to the 2.22.0 milestone Jan 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DDF-5635: Attach dependency check report to build.#5643

DDF-5635: Attach dependency check report to build.#5643
shaundmorris merged 1 commit into
codice:masterfrom
AdamBurstynski:archive_owasp_report

AdamBurstynski commented Nov 27, 2019

Uh oh!

AdamBurstynski commented Nov 27, 2019

Uh oh!

cxbot commented Nov 27, 2019

Uh oh!

TonyMorrison left a comment

Uh oh!

cxbot commented Nov 27, 2019

Uh oh!

shaundmorris Dec 2, 2019

Uh oh!

LinkMJB Dec 3, 2019

Uh oh!

AdamBurstynski Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

AdamBurstynski commented Nov 27, 2019

What does this PR do?

Who is reviewing it?

Select relevant component teams:

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Checklist:

Notes on Review Process

Review Comment Legend:

Uh oh!

AdamBurstynski commented Nov 27, 2019

Uh oh!

cxbot commented Nov 27, 2019

Uh oh!

TonyMorrison left a comment

Choose a reason for hiding this comment

Uh oh!

cxbot commented Nov 27, 2019

Uh oh!

shaundmorris Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

LinkMJB Dec 3, 2019

Choose a reason for hiding this comment

Uh oh!

AdamBurstynski Dec 3, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants