Skip to content

DDF-5597 updated dependency-check properties for local NVD #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaundmorris merged 2 commits into from
Dec 19, 2019
Merged

DDF-5597 updated dependency-check properties for local NVD #5654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb28d5
DDF-5597 updated dependency-check properties
shaundmorris Nov 18, 2019
a73f792
DDF-5597 added back dependency-check maven version
shaundmorris Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@
<lucene.version>7.7.2</lucene.version>
<lux.version>1.2</lux.version>
<lux.saxon.version>9.5.1-3</lux.saxon.version>
<mariadb.version>2.4.1</mariadb.version>
<maven.failsafe.version>3.0.0-M3</maven.failsafe.version>
<maven.surefire.version>3.0.0-M3</maven.surefire.version>
<!-- Mina version is not the latest version due to Apache FTPServer 1.0.6 not supporting newer releases properly -->
Expand Down Expand Up @@ -431,14 +432,25 @@
<groupId>org.owasp</groupId>
<artifactId>dependency-check-maven</artifactId>
<version>${dependency-check-maven.version}</version>
Copy link
Copy Markdown
Contributor

@brjeter brjeter Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ The version is defined in the dependencyManagement section of ddf-parent, right?

Copy link
Copy Markdown
Member Author

@shaundmorris shaundmorris Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. Looks like I made a mistake here, but it still works. I'll put the version back in. It seems like it grabs the latest version of dependency-check (5.2.4) and runs it just fine. There would be a pro to getting the latest, it just wouldn't be stable. Currently we are using 5.2.2 so might be time to upgrade again

<dependencies>
<dependency>
<groupId>ddf.support</groupId>
<artifactId>support-owasp</artifactId>
<version>${ddf.support.version}</version>
</dependency>
<dependency>
<groupId>org.mariadb.jdbc</groupId>
<artifactId>mariadb-java-client</artifactId>
<version>${mariadb.version}</version>
</dependency>
</dependencies>
<configuration>
<!-- The following properties enable using a mirror for nist NVD data -->
<cveUrlModified>${owasp.cveUrlModified}</cveUrlModified>
<cveUrlBase>${owasp.cveUrlBase}</cveUrlBase>
<!-- End NVD mirror configuration -->
<!-- Commented out as we make a process for handling these -->
<!--<failBuildOnCVSS>7</failBuildOnCVSS>-->
<!-- occasionally seeing a "Failed to request component-reports" error -->
<!-- The following properties enable using a centralized nvd server -->
<autoUpdate>${owasp.autoUpdate}</autoUpdate>
<databaseDriverName>${owasp.database.driverName}</databaseDriverName>
<connectionString>${owasp.database.url}</connectionString>
<serverId>${owasp.serverId}</serverId>
<!-- End Centralized NVD Server Configuration -->
<failOnError>false</failOnError>
<skipTestScope>true</skipTestScope>
<!--Disable by plugin maintainer recommendation on https://github.com/jeremylong/DependencyCheck/issues/978#issuecomment-349620687-->
Expand Down