Skip to content

[2.21.x] DDF-5597 updated dependency-check properties for local NVD (#5654)#5725

Merged
LinkMJB merged 1 commit into
codice:2.21.xfrom
shaundmorris:DDF-5597_2_21_x
Mar 19, 2020
Merged

[2.21.x] DDF-5597 updated dependency-check properties for local NVD (#5654)#5725
LinkMJB merged 1 commit into
codice:2.21.xfrom
shaundmorris:DDF-5597_2_21_x

Conversation

@shaundmorris
Copy link
Copy Markdown
Member

@shaundmorris shaundmorris commented Dec 19, 2019

  • DDF-5597 updated dependency-check properties

  • DDF-5597 added back dependency-check maven version

What does this PR do?

Backport to 2.21.x

Who is reviewing it?

@AdamBurstynski
@TonyMorrison
@LinkMJB
@mojogitoverhere

Select relevant component teams:

@codice/build
@codice/continuous-integration
@codice/security

Ask 2 committers to review/merge the PR and tag them here.

@brjeter
@oconnormi

How should this be tested?

Build passes and uses local NVD with the owasp profile

Any background context you want to provide?

What are the relevant tickets?

Fixes: #5597

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

This change is Reviewable

* DDF-5597 updated dependency-check properties

* DDF-5597 added back dependency-check maven version
@shaundmorris shaundmorris changed the title DDF-5597 updated dependency-check properties for local NVD (#5654) [2.21.x] DDF-5597 updated dependency-check properties for local NVD (#5654) Dec 19, 2019
@shaundmorris
Copy link
Copy Markdown
Member Author

build now

@cxbot
Copy link
Copy Markdown

cxbot commented Dec 19, 2019

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link
Copy Markdown

cxbot commented Dec 20, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/2.21.x/job/pr/job/Linux/7/
✅ JOB SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2019

Codecov Report

Merging #5725 into 2.21.x will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             2.21.x    #5725   +/-   ##
=========================================
  Coverage     62.91%   62.91%           
  Complexity    16365    16365           
=========================================
  Files          1628     1628           
  Lines         93467    93467           
  Branches      11320    11320           
=========================================
  Hits          58803    58803           
+ Misses        30406    30403    -3     
- Partials       4258     4261    +3

@shaundmorris
Copy link
Copy Markdown
Member Author

build now

@cxbot
Copy link
Copy Markdown

cxbot commented Jan 3, 2020

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link
Copy Markdown

cxbot commented Jan 3, 2020

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/2.21.x/job/pr/job/Linux/8/
❌ JOB FAILURE

@stale
Copy link
Copy Markdown

stale Bot commented Mar 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@stale stale Bot added the wontfix label Mar 19, 2020
@LinkMJB
Copy link
Copy Markdown
Contributor

LinkMJB commented Mar 19, 2020

build now

@stale stale Bot removed the wontfix label Mar 19, 2020
@cxddfbot
Copy link
Copy Markdown

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link
Copy Markdown

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@shaundmorris
Copy link
Copy Markdown
Member Author

Build now

last error: Remote call to JNLP4-connect connection

@cxddfbot
Copy link
Copy Markdown

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link
Copy Markdown

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@LinkMJB LinkMJB merged commit 9ca1159 into codice:2.21.x Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants