Skip to content

[2.21.x] DDF-5946 Update Intrigue to respect Subject Identity configuration#5947

Merged
stustison merged 3 commits into
codice:2.21.xfrom
SmithJosh:DDF-5946-2.21.x
Mar 30, 2020
Merged

[2.21.x] DDF-5946 Update Intrigue to respect Subject Identity configuration#5947
stustison merged 3 commits into
codice:2.21.xfrom
SmithJosh:DDF-5946-2.21.x

Conversation

@SmithJosh
Copy link
Copy Markdown
Contributor

What does this PR do?

Removes all hardcoded uses of email as the subject identity. Now Intrigue uses the attribute set in the Subject Identity configuration.

Who is reviewing it?

@stustison @brendan-hofmann @beyelerb

Select relevant component teams:

How should this be tested?

  1. Create two non-admin accounts in DDF
  2. Change the Subject Identity config in the Admin UI to use the http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier attribute instead of email.
  3. Restart DDF
  4. Verify the following:
  • Metacard security attributes (the security.access-* attributes) use the name identifier instead of email.
  • The workspaces page use the name identifier to indicate workspace ownership
  • Workspace filtering works (Owned by Me, Not Owned by Me)
  • Workspace sharing works
  • Search form sharing works (top left hamburger > Search Forms)
  • On load, Intrigue opens an existing workspace if there is one owned by the current user
  • Query annotations use name identifier to indicate ownership, and only the owner can modify their notes.

Any background context you want to provide?

What are the relevant tickets?

Fixes: #5946

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 26, 2020

CLA assistant check
All committers have signed the CLA.

@SmithJosh SmithJosh changed the base branch from master to 2.21.x March 26, 2020 23:38
@SmithJosh
Copy link
Copy Markdown
Contributor Author

build now

@SmithJosh
Copy link
Copy Markdown
Contributor Author

build now

@cxddfbot
Copy link
Copy Markdown

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link
Copy Markdown

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@SmithJosh
Copy link
Copy Markdown
Contributor Author

Jenkins failed to checkout PR. build now

@cxddfbot
Copy link
Copy Markdown

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link
Copy Markdown

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@SmithJosh
Copy link
Copy Markdown
Contributor Author

Same issue. I'm going to try one more time. build now

@cxddfbot
Copy link
Copy Markdown

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link
Copy Markdown

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@stustison stustison merged commit 58d7ffb into codice:2.21.x Mar 30, 2020
@SmithJosh SmithJosh deleted the DDF-5946-2.21.x branch March 30, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intrigue does not respect the Subject Identity configuration

6 participants