[2.21.x] DDF-5946 Update Intrigue to respect Subject Identity configuration#5947
Merged
Conversation
SmithJosh
commented
Mar 26, 2020
Contributor
Author
|
build now |
stustison
approved these changes
Mar 26, 2020
Contributor
Author
|
build now |
|
Internal build has been started, your results will be available at build completion. |
brendan-hofmann
approved these changes
Mar 27, 2020
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
beyelerb
approved these changes
Mar 27, 2020
Contributor
Author
|
Jenkins failed to checkout PR. build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Contributor
Author
|
Same issue. I'm going to try one more time. build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes all hardcoded uses of email as the subject identity. Now Intrigue uses the attribute set in the Subject Identity configuration.
Who is reviewing it?
@stustison @brendan-hofmann @beyelerb
Select relevant component teams:
How should this be tested?
http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifierattribute instead of email.Any background context you want to provide?
What are the relevant tickets?
Fixes: #5946
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: