User moderator tools user interface redesign

[trichoplax]

This converts the user moderation tools from a pop up panel on the user page to a tab at the top of the user page. On desktop this has a left hand panel listing all of the user moderation tools. On mobile this list is available by pressing "Show User Moderation Tools" near the top of the tab.

Note that this change also includes some tidying: code formatting to match the style guide and use of the new user model methods such as admin? instead of is_admin. Please let me know if you would prefer any of these to be a separate pull request. My aim has been to get these out of the way now to minimise such changes in later user moderator tools pull requests.

[cellio]

I ran through the new tools pages and everything looks good. I'll file follow-on issues for the things we decided (in the previous PR) to defer.

[Oaphi]

This looks like a good candidate for a loop, this is way too many ORs for one method

[trichoplax]

Oh good point. I did some searching and I've found 2 approaches. I've implemented one, but the following also works:

  def user_mod_tools_tab_active?(user)
    user_mod_tools_tab_pages = [
      mod_user_url(user),
      full_user_log_url(user),
      user_annotations_url(user),
      mod_vote_summary_url(user),
      user_privileges_url(user),
      mod_warning_log_url(user),
      new_mod_warning_url(user),
      mod_delete_url(user),
      mod_pii_correlation_url(user),
      mod_delete_network_account_url(user),
      mod_failban_url(user),
      start_impersonating_url(user)
    ]

    user_mod_tools_tab_pages.any? { |page| current_page?(page) }
  end

I'm not sure which would be more readable, so let me know if you'd prefer the other approach (or if there's a better approach I haven't considered).

[Oaphi]

I was thinking about something a bit more succinct - what'd you say if took this approach instead:

def user_mod_tools_tab_active?(user)
    methods = [
      :mod_user,
      :full_user_log,
      :user_annotations,
      :mod_vote_summary,
      :user_privileges,
      :mod_warning_log,
      :new_mod_warning,
      :mod_delete,
      :mod_pii_correlation,
      :mod_delete_network_account,
      :mod_failban,
      :start_impersonating
    ]

    methods.any? { |name| current_page?(send("#{name}_url", user)) }
  end

[Oaphi]

current_page? also accepts controller and action options so we could use that form to simplify even further.