Skip to content

Fix identical operator by casting parameters in RequestBodyRange #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

Fix identical operator by casting parameters in RequestBodyRange #33

merged 1 commit into from
Mar 6, 2020

Conversation

@nerg4l
Copy link
Member

@nerg4l nerg4l commented Mar 5, 2020 •
edited
Loading

Parameters from a request are strings but the identical operator (===) will compare it with an int or a float which will always return false.

This PR fixes this issue by casting the strings to the proper type.

@nerg4l nerg4l requested a review from a team March 5, 2020 22:07
@nerg4l nerg4l merged commit c374450 into coding-socks:master Mar 6, 2020
@nerg4l nerg4l deleted the bugfix/parameter-type branch March 6, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axlon axlon axlon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nerg4l @axlon