Skip to content

Conversation

@nerg4l
Copy link
Member

@nerg4l nerg4l commented Mar 6, 2020

This PR fixes the dependencies in composer which was missing from #31 and fixes the dependencies in GitHub Actions which was miss typed in #32

@nerg4l nerg4l requested a review from a team March 6, 2020 10:23
@nerg4l
Copy link
Member Author

nerg4l commented Mar 6, 2020

For some unknown reason Scrutinizer was stuck in "Waiting for External Code Coverage" state so I moved from External Code Coverage to Generating Code Coverage.

scrutinizer-ci/scrutinizer#346

I would recommend to run the coverage generation on Scrutinizer (even if that means running tests twice), the set-up is just much more robust then.

@nerg4l nerg4l merged commit 70d8120 into coding-socks:master Mar 6, 2020
@nerg4l nerg4l deleted the bugfix/fix-dependencies branch March 6, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant