Potential fix for code scanning alert no. 4: DOM text reinterpreted as HTML - #16
Merged
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/codinglombok/LombokCSS/security/code-scanning/4
Best-practice fix: validate and constrain DOM-derived values before using them to build URLs/attributes, and build query strings with
URLSearchParamsso values are encoded safely.For this file, the strongest minimal fix is:
style,theme,dir, anddata-page.data-style-set.new URLSearchParams(...).toString().hrefwhendata-pageis a safe relative page token (nojavascript:, no absolute URL, no dangerous chars).This addresses both variants by ensuring DOM text is normalized before any downstream use.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.