ODS API querying helpers#116
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 87.7% 88.74% +1.03%
==========================================
Files 26 28 +2
Lines 553 604 +51
==========================================
+ Hits 485 536 +51
Misses 68 68
Continue to review full report at Codecov.
|
murd0
suggested changes
Jan 28, 2020
murd0
left a comment
Contributor
There was a problem hiding this comment.
Nice stuff Mike, really relevant for codon too. Thanks for adding your module to the docs too... It's a bit annoying that that has to be done for every addition. The overhead should be less when we have enough material to make real modules that can be autodoc'd though.
murd0
reviewed
Jan 28, 2020
murd0
approved these changes
Jan 29, 2020
murd0
left a comment
Contributor
There was a problem hiding this comment.
Thanks for prompt resolution of the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple of new functions for querying the ODS API. The main one,
ODS_lookup.get_addresses, can be used to retrieve name and address information for a list of ODS codes as a pandas data frame. e.g.The api only lets you query for a single code at a time. I don't think making serial requests is going to cause a major performance issue but it might for very large requests. Could investigate async requests if necessary.