Skip to content

v0.2.3#122

Merged
georgeRobertson merged 4 commits into
masterfrom
dev
Apr 20, 2020
Merged

v0.2.3#122
georgeRobertson merged 4 commits into
masterfrom
dev

Conversation

@murd0

@murd0 murd0 commented Apr 20, 2020

Copy link
Copy Markdown
Contributor
  • Please check if the Pull Request fulfills these requirements
  • [ x ] The commit message is clear and concise
  • [ x ] Test for the changes have been added and reviewed
  • [ x ] Documentation has been added to all new features and edited code has had documentation reviewed

Khoross and others added 3 commits March 10, 2020 09:25
* Migrate across MESH api connection scripts and teses

* Add MESH to documentation and adding example usage

* Include dataclasses in requirements for py3.6

* Update tests to match new return structure

* Fix flake8 issues

* Add tests for early halt if entire inbox errors

* Additional error test cases to get coverage to 100

* Various header fixes due to undocumented API behaviour

Co-authored-by: Chris Daniels <CHDA5@hscic.gov.uk>
@murd0 murd0 requested a review from georgeRobertson April 20, 2020 09:14
@codecov

codecov Bot commented Apr 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #122 into master will increase coverage by 5.98%.
The diff coverage is 98.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   88.74%   94.72%   +5.98%     
==========================================
  Files          28       44      +16     
  Lines         604     1480     +876     
==========================================
+ Hits          536     1402     +866     
- Misses         68       78      +10     
Impacted Files Coverage Δ
...odonPython/validation/check_consistent_measures.py 86.66% <ø> (ø)
...nPython/validation/check_consistent_submissions.py 100.00% <ø> (ø)
codonPython/validation/check_nat_val.py 100.00% <ø> (ø)
codonPython/validation/check_null.py 100.00% <ø> (ø)
codonPython/validation/dateValidator.py 100.00% <ø> (ø)
codonPython/validation/tolerance.py 100.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
codonPython/mesh/exceptions.py 72.72% <72.72%> (ø)
codonPython/mesh/tests/test_check_and_download.py 98.36% <98.36%> (ø)
codonPython/mesh/__init__.py 100.00% <100.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b808e7e...26bc427. Read the comment docs.

@georgeRobertson georgeRobertson merged commit 2440a4f into master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants