Skip to content

[PRAC-259] Clarify learning chart units - #117

Merged
Kuba0517 merged 1 commit into
mainfrom
feature/PRAC-259-improve-activity-chart-values
Feb 9, 2026
Merged

[PRAC-259] Clarify learning chart units#117
Kuba0517 merged 1 commit into
mainfrom
feature/PRAC-259-improve-activity-chart-values

Conversation

@Kuba0517

@Kuba0517 Kuba0517 commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • New Features
    • Dashboard charts now support multiple metrics: learning time, XP, and task counts
    • Chart values automatically format based on your selected metric for proper display
    • Learning dashboard metric selector now properly syncs with chart visualization

@Kuba0517
Kuba0517 merged commit da94077 into main Feb 9, 2026
4 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Feb 9, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce metric selection support to the PlaceholderChart component. A new metric prop is added to the PlaceholderChart, a formatter function formatMetricValue converts values based on metric type, and the LearningDashboard wires the selected metric to the chart for display.

Changes

Cohort / File(s) Summary
Chart Metric Support
frontend/src/features/learning/dashboard/placeholder-chart.tsx
Added metric prop to PlaceholderChart with default value GetActivityChartMetric.LEARNING_TIME. Extended BarChartComponent to accept and utilize metric parameter. Introduced formatMetricValue(value, metric) formatter function to convert raw values to human-readable strings (sec/min/h, XP, or tasks) based on selected metric.
Metric Integration
frontend/src/features/learning/my-learning/learning-dashboard.tsx
Passed selectedMetric state to PlaceholderChart component via new metric prop to align chart rendering with user's selected metric.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A metric so fine, now woven with care,
Charts shift their measure through the dashboard air,
Time, XP, tasks—each value glows bright,
The formatter hops, making all metrics just right!


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kuba0517
Kuba0517 deleted the feature/PRAC-259-improve-activity-chart-values branch February 9, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant