Skip to content

Update OIDC config to match dotnet utils - #73

Merged
mathialo merged 2 commits into
masterfrom
CDF-9494
Oct 20, 2020
Merged

Update OIDC config to match dotnet utils#73
mathialo merged 2 commits into
masterfrom
CDF-9494

Conversation

@mathialo

Copy link
Copy Markdown
Contributor
  • Allow multiple scopes
  • Configurable authority

 * Allow multiple scopes
 * Configurable authority
@mathialo
mathialo requested a review from a team October 19, 2020 12:40
@codecov

codecov Bot commented Oct 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #73 into master will increase coverage by 1.25%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   78.17%   79.43%   +1.25%     
==========================================
  Files           8        8              
  Lines         834      851      +17     
==========================================
+ Hits          652      676      +24     
+ Misses        182      175       -7     
Impacted Files Coverage Δ
cognite/extractorutils/authentication.py 85.00% <66.66%> (-1.12%) ⬇️
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/uploader.py 78.26% <0.00%> (+0.14%) ⬆️
cognite/extractorutils/configtools.py 68.31% <0.00%> (+6.01%) ⬆️

@sebbert sebbert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathialo
mathialo merged commit 68760c9 into master Oct 20, 2020
@mathialo
mathialo deleted the CDF-9494 branch October 20, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants