Add support for command invocation with a 'default verb'#656
Merged
Conversation
There are no plans to use this feature to allow the 'colcon' executable to be invoked without a verb, but other tools built on colcon-core's framework may not want multiple verbs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
==========================================
+ Coverage 87.27% 87.34% +0.07%
==========================================
Files 67 67
Lines 3906 3913 +7
Branches 774 776 +2
==========================================
+ Hits 3409 3418 +9
Misses 391 391
+ Partials 106 104 -2 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Jul 25, 2024
nuclearsandwich
approved these changes
Jul 25, 2024
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Re-review for the class instance -> class type changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no plans to use this feature to allow the 'colcon' executable to be invoked without a verb, but other tools built on colcon-core's framework may not want multiple verbs.