Skip to content

Conversation

@taughz
Copy link

@taughz taughz commented Dec 20, 2024

Uploading tarballs with - instead of _ results in the following email sent to the uploader:

In the future, PyPI will require all newly uploaded source
distribution filenames to comply with PEP 625. Any source
distributions already uploaded will remain in place as-is and do not
need to be updated.

Specifically, your recent upload of 'package-name-0.0.1.tar.gz' is
incompatible with PEP 625 because it does not contain the normalized
project name 'package_name'.

In most cases, this can be resolved by upgrading the version of your
build tooling to a later version that supports PEP 625 and produces
compliant filenames.

@taughz
Copy link
Author

taughz commented Dec 20, 2024

I did not attempt to change stdeb related functionality. So those are still using setup.py. I'm mostly trying to make PyPI happy.

There is an assumption here that build has been installed. I was not sure how best to express that dependency. The CI workflow might need to be updated, for example here: https://github.com/colcon/ci/blob/17cac168e05b5c0d109a5e482eaeb60708b3307e/action.yaml#L17

@taughz taughz marked this pull request as draft December 20, 2024 16:51
Uploading tarballs with `-` instead of `_` results in the following
email sent to the uploader:

> In the future, PyPI will require all newly uploaded source
> distribution filenames to comply with PEP 625. Any source
> distributions already uploaded will remain in place as-is and do not
> need to be updated.

> Specifically, your recent upload of 'package-name-0.0.1.tar.gz' is
> incompatible with PEP 625 because it does not contain the normalized
> project name 'package_name'.

> In most cases, this can be resolved by upgrading the version of your
> build tooling to a later version that supports PEP 625 and produces
> compliant filenames.
@cottsay
Copy link
Member

cottsay commented Jan 28, 2025

The issue with PEP 625 was resolved by #3. I believe that the reason you're seeing the warning is because you're using an older version of setuptools that doesn't implement PEP 625. Switching to using build resolves the issue for you because it builds the package in a sandbox with a newer version of setuptools than you were using before outside of the sandbox.

@cottsay cottsay changed the title Fix PyPI PIP 625 incompatibility Fix PyPI PEP 625 incompatibility Jan 28, 2025
@taughz
Copy link
Author

taughz commented Jan 28, 2025

Oh, good to know. I think we can close this PR then.

@taughz taughz closed this Jan 28, 2025
@taughz taughz deleted the fix-pip-625 branch January 28, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants