fix: harden reliability audit edge cases#22
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds overflow-safe scan aggregation, bounded scan archive reads, tree-aware search index caching, and full-scan fallback for failed incremental scans. It also updates related tests for archive limits, reconciliation, search isolation, treemap hit-testing, and integer clamping. ChangesOverflow-Safe Integer Accumulation
Bounded Archive Section Reading
File Search Index Cache Key Fix
Incremental Scan Fallback to Full Scan
Confirm-Move Trash Batch Test Update
Treemap Hit-Testing Fractional Size Test
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
RadixCoreTests/TreemapGeometryTests.swift (1)
186-186: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd a failure message with the sampled point for easier debugging.
If a mismatch occurs, the bare
XCTAssertEqualwon't indicate which point triggered it. Including the point coordinates in the failure message would significantly reduce debugging time.🔧 Suggested improvement
- XCTAssertEqual(index.segment(at: point, in: size)?.id, expected?.id) + XCTAssertEqual( + index.segment(at: point, in: size)?.id, + expected?.id, + "Hit-test mismatch at point \(point)" + )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@RadixCoreTests/TreemapGeometryTests.swift` at line 186, Update the XCTAssertEqual assertion in the treemap geometry test to include the sampled point’s coordinates in its failure message, while preserving the existing ID comparison and expected-value behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Radix/Services/FileBrowserSearch.swift`:
- Line 66: Update the cache-miss assignment in the index lookup flow to mutate
the existing indexes dictionary by key rather than replacing the dictionary.
Make the assignment at the line-66 cache path match the keyed update already
used in the corresponding flow near line 102, preserving previously cached tree
indexes.
---
Nitpick comments:
In `@RadixCoreTests/TreemapGeometryTests.swift`:
- Line 186: Update the XCTAssertEqual assertion in the treemap geometry test to
include the sampled point’s coordinates in its failure message, while preserving
the existing ID comparison and expected-value behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ef4546f8-c4c9-4131-b524-d626f3d274fd
📒 Files selected for processing (16)
Package.swiftRadix/Services/AtomicDirectoryParallelSummary.swiftRadix/Services/AtomicDirectorySummaryModels.swiftRadix/Services/AtomicDirectorySummaryProbe.swiftRadix/Services/AtomicDirectorySummaryWalker.swiftRadix/Services/FileBrowserSearch.swiftRadix/Services/IncrementalScanService.swiftRadix/Services/ScanArchiveService.swiftRadix/Services/ScanEngine.swiftRadix/Services/ScanIntegerMath.swiftRadixCoreTests/AppModelDependencyTests.swiftRadixCoreTests/FileBrowserModelTests.swiftRadixCoreTests/IncrementalScanServiceTests.swiftRadixCoreTests/ScanArchiveServiceTests.swiftRadixCoreTests/ScanEngineTests.swiftRadixCoreTests/TreemapGeometryTests.swift
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit