Skip to content

Fix typo in survive_simple_object_charge_percet (percent)#365

Merged
bl4ckb0ne merged 1 commit into
collabora:masterfrom
yume02kki:fix/charge-percent-typo
Jul 6, 2026
Merged

Fix typo in survive_simple_object_charge_percet (percent)#365
bl4ckb0ne merged 1 commit into
collabora:masterfrom
yume02kki:fix/charge-percent-typo

Conversation

@yume02kki

Copy link
Copy Markdown
Contributor

Fix function typo, close relevant issue:
github.com/collabora/libsurvive/issues/337

@bl4ckb0ne

Copy link
Copy Markdown
Collaborator

Thanks!

@hypevhs

hypevhs commented Jul 10, 2026

Copy link
Copy Markdown

This broke my Monado build, though I am not trying to use libsurvive at all. So I added the xr service cmake XRT_BUILD_DRIVER_SURVIVE=OFF for the time being.

@bl4ckb0ne

Copy link
Copy Markdown
Collaborator

Could you please report an issue to monado?

@Scrumplex

Copy link
Copy Markdown

We ran into the same issue in nix-community/nixpkgs-xr#761.

Shouldn't libsurvive ship a deprecated alias for the old spelling?

@yume02kki

Copy link
Copy Markdown
Contributor Author

This broke my Monado build, though I am not trying to use libsurvive at all. So I added the xr service cmake XRT_BUILD_DRIVER_SURVIVE=OFF for the time being.

We ran into the same issue in nix-community/nixpkgs-xr#761.

Shouldn't libsurvive ship a deprecated alias for the old spelling?

In-order to not break stuff, Ive added an Alias for the old misspelled method name with a deprecated tag, Hope this helps :-)

@bl4ckb0ne

Copy link
Copy Markdown
Collaborator

Let's move the discussion to #366 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants