Skip to content

Fix fedora_main build - #84

Merged
eero-t merged 1 commit into
collectd:mainfrom
matwey:fedora_main
Sep 15, 2025
Merged

Fix fedora_main build#84
eero-t merged 1 commit into
collectd:mainfrom
matwey:fedora_main

Conversation

@matwey

@matwey matwey commented Sep 5, 2025

Copy link
Copy Markdown
Contributor
  • --skip-broken has been dropped from dnf since it has no effect.

@eero-t

eero-t commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

--skip-broken has been dropped from dnf since it has no effect.

Please update description: s/dnf/yum/

Fix looks correct, as in e.g. Fedora 42:

$ yum update --help | grep -e skip -e broken
  --skip-unavailable                           Allow skipping unavailable packages

But because top README states:

There is one branch per distribution/version against which collectd is tested. Common bits, most notably GitHub Actions, are stored in the main branch, and merged into the distro branches when needed.

I wonder whether this should rather go through main branch?

After which somebody with access to this repo (@mrunge?), would need to rebase other relevant branches...

 * --skip-broken has been dropped from yum since it has no effect.
@matwey
matwey changed the base branch from fedora_main to main September 13, 2025 08:14
@matwey

matwey commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

It seems that it safe to put this to main branch

@eero-t
eero-t merged commit a30c4c8 into collectd:main Sep 15, 2025
1 check failed
@eero-t

eero-t commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

README states:

There is one branch per distribution/version against which collectd is tested. Common bits, most notably GitHub Actions, are stored in the main branch, and merged into the distro branches when needed.

Merged to main. @mrunge How this fix gets "merged" into the specific distro version branches using DNF?

(@matwey If Matthias does not answer in few days, I guess PRs to the other branches are still needed...)

@mrunge

mrunge commented Sep 16, 2025

Copy link
Copy Markdown
Member

I need to read back how the ci was built. I remember it was somewhat complicated and there are branches for every release.

@mrunge

mrunge commented Sep 16, 2025

Copy link
Copy Markdown
Member

The container check failed on the dpdkevents plugin. I'd skip it for now without actually looking why it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants