Skip to content

DRYD-2015: Report > Public Art > Full object with place details > place type (placeType) and placement type (placementType) - #501

Merged
spirosdi merged 4 commits into
mainfrom
bugfix/dryd-2015
Feb 6, 2026
Merged

DRYD-2015: Report > Public Art > Full object with place details > place type (placeType) and placement type (placementType)#501
spirosdi merged 4 commits into
mainfrom
bugfix/dryd-2015

Conversation

@spirosdi

@spirosdi spirosdi commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

What does this do?
For the "Public Art > Full object with place details" and "Public Art > Full Object with Place Details: Creator Name and Role Combined" reports, it aggregates all place types and placement types.

Why are we doing this? (with JIRA link)
Reports should produce output of multiple place types and placement types and not just the first one. https://collectionspace.atlassian.net/browse/DRYD-2015

How should this be tested? Do these changes have associated tests?
Using the public art profile

  1. Create a Place Authority with multiple "Placement type" and multiple "Place type"
  2. Create a new Object
  3. Relate a LMI to it, by creating a new Location with the "Current Location > Location" field set to the Place created in step 1
  4. Navigate to Tools > Reports > Full object with place details, run the report on "single record" and search and select the Object created in step 2
  5. Confirm that the "Placement Type" and "Place Type" contains the multiple values set in step 1, separated by semicolon
  6. Repeat steps 4 and 5 for "Full Object with Place Details: Creator Name and Role Combined" report

Dependencies for merging? Releasing to production?
No dependencies

Has the application documentation been updated for these changes?
The relevant report documentation should be updated accordingly

Did someone actually run this code to verify it works?
@spirosdi ran it locally

Have any new security vulnerabilities been handled?
no new security vulnerabilities

@spirosdi
spirosdi requested a review from mikejritter February 4, 2026 16:38

@mikejritter mikejritter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both reports and see the aggregated place and placement types.

@spirosdi
spirosdi merged commit 1b58322 into main Feb 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants