no-jira: changed tenant.ui.profile.plugin build branch to develop; - #545
Merged
Conversation
Contributor
Author
|
@mikejritter , I will merge this PR now so that Jessi has a chance to check the home location before her time off. In any case, please do check the change when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It changes the
tenant.ui.profile.plugin.build.branchbuild property todevelopfrommainfor all the profiles.Why are we doing this? (with JIRA link)
Now the new ui profile plugin patch versions are getting released automatically. So for all the ui profile plugin repos, we need a ready-to-release
mainbranch and adevelopone for the development work. Similar to the cspace-ui. We also need to build thedevelopbranch instead of themainbranch when deploying withCSPACE_UI_BUILDenv var set to true.How should this be tested? Do these changes have associated tests?
Locally, please set the
CSPACE_UI_BUILDenv var totrue. Then build and deploy. Confirm that the build is green and when opening the different http://localhost:8180/cspace/{profile}/welcome screens, the UI version commit is set to the one last pushed to thedevelopbranch (for the botgarden, herbarium and bonsai the commit is the same in bothmainanddevelopbranch). Please check all the profiles:Dependencies for merging? Releasing to production?
No dependencies
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@spirosdi ran it locally
Have any new security vulnerabilities been handled?
N/A