Conversation
B1ueber2y
approved these changes
Nov 23, 2025
| @@ -257,6 +258,9 @@ include_directories(src) | |||
| link_directories(${COLMAP_LINK_DIRS}) | |||
|
|
|||
| add_subdirectory(src/colmap) | |||
Contributor
There was a problem hiding this comment.
Realizing that, here by concept thirdparty should be put before colmap, although in the current design it does not matter since we dont define any target in the thirdparty.
| else() | ||
| target_compile_options(colmap_glomap PRIVATE | ||
| -Wall | ||
| -Wno-sign-compare |
Contributor
There was a problem hiding this comment.
Disabling sign-compare and unused-variable is never a good practice? But I understand that this might be a temporary solution for the migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled by default, passes all tests, follow-up with further refactoring steps.