Fixes #1: Prevent Connection Storms and MaxConns Violations in pgxpool - #2
Merged
Merged
Conversation
colmev080
approved these changes
Aug 6, 2026
colmev080
left a comment
colmev080
left a comment
Owner
There was a problem hiding this comment.
PR approved via GitBountyCreator automation! Seamless merge and bounty disbursement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the race condition where multiple goroutines could initiate connection attempts simultaneously, leading to exceeding the
MaxConnslimit.Changes:
inFlightConnstopgxpool.Poolto track pending connection attempts.Acquirelogic to checklen(conns) + inFlightConns < MaxConnsbefore attempting a new connection.inFlightConnsis decremented on both success and failure of connection establishment.Fixes #1