Skip to content

Fix test failures in RequestTests #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fix test failures in RequestTests #27

merged 1 commit into from
Jan 22, 2019

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Jan 22, 2019 •
edited
Loading

This PR addresses issue #25 by fixing all test failures in RequestTests:

@lihaoyi lihaoyi merged commit a62fbf7 into com-lihaoyi:master Jan 22, 2019
@liancheng liancheng mentioned this pull request Jan 22, 2019
Closed
tanishiking added a commit to tanishiking/requests-scala that referenced this pull request Nov 29, 2025
@tanishiking
Use badssl.com for testing verifySslCerts=false
43453d3 
We use https://expired.badssl.com for invalid cert test
com-lihaoyi#27
but we still used doesnt-exist[dot]com for testing `verifySslCerts = false`
@tanishiking tanishiking mentioned this pull request Nov 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liancheng @lihaoyi