Refactorings #61
Merged
Refactorings #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Nov 27, 2018
Collaborator
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
LGTM 👍 The diff is quite difficult to read but SourceContext.scala is nicer on the eye now with all the macro code moved into a separate file https://github.com/lihaoyi/sourcecode/blob/6be8b040a4f0c9ab3d10b6b8b66f1bf7f5360d68/sourcecode/shared/src/main/scala/sourcecode/SourceContext.scala
It might be good to enable mima to know if these changes cause binary incompatibilities. I suspect there are no bincompat issues here since calls to the implicit generate methods do not exist in bytecode.
Collaborator
Author
|
Agreed with mima. I'll probably add it another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are simple refactorings, that make it easier to add dotty support later on (will update #60 with it once this is merged).