Skip to content

fix: do not include standard html tag names in heading slugs - #309

Merged
farnabaz merged 2 commits into
comarkdown:mainfrom
danielroe:fix/heading-slugs
Jul 30, 2026
Merged

fix: do not include standard html tag names in heading slugs#309
farnabaz merged 2 commits into
comarkdown:mainfrom
danielroe:fix/heading-slugs

Conversation

@danielroe

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

it would surprise me if we wanted to have the names of html elements in the generated heading ids, but I might be wrong...

📝 Checklist

  • I have linked an issue or discussion.
  • I have run pnpm verify and it passes.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from farnabaz as a code owner July 29, 2026 15:47
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

@danielroe is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@danielroe
danielroe force-pushed the fix/heading-slugs branch from 217599d to fee52b0 Compare July 29, 2026 15:56
@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@309

@comark/angular

npm i https://pkg.pr.new/@comark/angular@309

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@309

@comark/html

npm i https://pkg.pr.new/@comark/html@309

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@309

@comark/react

npm i https://pkg.pr.new/@comark/react@309

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@309

@comark/vue

npm i https://pkg.pr.new/@comark/vue@309

commit: fee52b0

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comark Ready Ready Preview Jul 29, 2026 4:07pm
comark-json-render Ready Ready Preview Jul 29, 2026 4:07pm
comark-nextjs Ready Ready Preview Jul 29, 2026 4:07pm
comark-nuxt Ready Ready Preview Jul 29, 2026 4:07pm
comark-svelte Ready Ready Preview Jul 29, 2026 4:07pm
comark-sveltekit Ready Ready Preview Jul 29, 2026 4:07pm
comark-twoslash Ready Ready Preview Jul 29, 2026 4:07pm
comark-vue Ready Ready Preview Jul 29, 2026 4:07pm

@farnabaz farnabaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks

@farnabaz
farnabaz merged commit 0cd5f83 into comarkdown:main Jul 30, 2026
11 checks passed
@danielroe
danielroe deleted the fix/heading-slugs branch July 30, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants