Skip to content

revert: "fix(highlight): accept bundled theme names in themes option (#308)" - #327

Merged
farnabaz merged 2 commits into
mainfrom
revert/shiki-theme-names
Aug 4, 2026
Merged

revert: "fix(highlight): accept bundled theme names in themes option (#308)"#327
farnabaz merged 2 commits into
mainfrom
revert/shiki-theme-names

Conversation

@farnabaz

@farnabaz farnabaz commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Keep explicit imports of the Shiki themes to be consistent with the Comark vision.

📝 Checklist

  • I have linked an issue or discussion.
  • I have run pnpm verify and it passes.
  • I have updated the documentation accordingly.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comark Ready Ready Preview Aug 4, 2026 10:50am
comark-json-render Ready Ready Preview Aug 4, 2026 10:50am
comark-nextjs Ready Ready Preview Aug 4, 2026 10:50am
comark-nuxt Ready Ready Preview Aug 4, 2026 10:50am
comark-svelte Ready Ready Preview Aug 4, 2026 10:50am
comark-sveltekit Ready Ready Preview Aug 4, 2026 10:50am
comark-twoslash Ready Ready Preview Aug 4, 2026 10:50am
comark-vue Ready Ready Preview Aug 4, 2026 10:50am

@pkg-pr-new

pkg-pr-new Bot commented Aug 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@327

@comark/angular

npm i https://pkg.pr.new/@comark/angular@327

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@327

@comark/html

npm i https://pkg.pr.new/@comark/html@327

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@327

@comark/react

npm i https://pkg.pr.new/@comark/react@327

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@327

@comark/vue

npm i https://pkg.pr.new/@comark/vue@327

commit: e54f42a

@farnabaz
farnabaz merged commit 6ed799b into main Aug 4, 2026
12 checks passed
@farnabaz
farnabaz deleted the revert/shiki-theme-names branch August 4, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant