[OPIK-7250] [FE] feat: theme-aware waste-* callout tokens (AI Spend)#7430
Merged
Conversation
Adds --waste-bg / --waste-border / --waste-text (light + dark) and their Tailwind color mappings, mirroring the existing warning-box-* set. Light: pale warm chip (#fee8d7 fill, #fb9341 border, black text); dark: subtle #fb9341/15 fill with a light warm text. Consumed by the AI-Spend "recoverable waste" callout in opik-plugin-ai-spend so it flips through the token system instead of hardcoded hex + manual dark: overrides. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
⏱️ pre-commit per-hook timing
⏭️ 40 skipped (no matching files changed)
|
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds a theme-aware
waste-*design-token set for the AI-Spend "recoverable waste" callout, so it flips light/dark through the token system instead of hardcoded hex + manualdark:overrides. Follow-up to review feedback onopik-plugin-ai-spend#25.apps/opik-frontend/src/main.scss—--waste-bg/--waste-border/--waste-textin both:rootand.dark(light:#fee8d7fill,#fb9341border, black text; dark:#fb9341@ 15% fill,#fb9341border,#fee8d7text), mirroring the existingwarning-box-*block.apps/opik-frontend/tailwind.config.ts—waste-bg/waste-border/waste-textcolor mappings (var(--waste-*), following thechart-*hex-var precedent so the dark fill's alpha survives).opik-plugin-ai-spend#30; merge this first — the plugin'swaste-*classes only resolve once these tokens exist.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
waste-*CSS variables (light + dark) and Tailwind color mappings.var(--waste-*)CSS and flip light/dark; frontend eslint + tsc pass.Testing
npx tsc --project tsconfig.json --noEmit— passes.npx eslint src/plugins/ai-spend— passes (the consuming plugin).npx tailwindcss -c tailwind.config.ts ...confirmsbg-waste-bg → background-color: var(--waste-bg),border-waste-border,text-waste-text,bg-waste-borderall emit.Documentation
No documentation changes — internal design tokens mirroring the existing
warning-box-*set.